Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #12883 accessibility issue by adding role attribute alongside aria-label #12889

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fixed #12883 accessibility issue by adding role attribute alongside aria-label #12889

merged 1 commit into from
Sep 15, 2023

Conversation

aviroopjana
Copy link
Contributor

@aviroopjana aviroopjana commented Sep 14, 2023 •
edited by stepankuzmin
Loading

Fixed accessibility issue by adding role attribute alongside aria-label. Closes #12883

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Add a role to the Marker element per W3 guidelines</changelog>

@aviroopjana aviroopjana requested a review from a team as a code owner September 14, 2023 05:04
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

EliRobinson
EliRobinson approved these changes Sep 14, 2023
View reviewed changes
Copy link

@EliRobinson EliRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@aviroopjana
Copy link
Contributor Author

@EliRobinson can you merge this PR?

stepankuzmin
stepankuzmin approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @aviroopjana

@stepankuzmin stepankuzmin merged commit c55ff82 into mapbox:main Sep 15, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

@EliRobinson EliRobinson EliRobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting aria-label on a div requires a role as well
4 participants
@aviroopjana @CLAassistant @stepankuzmin @EliRobinson